drop dead trait, dead test guards, and migrate async_mpi receiver to native P2300#7244
Merged
hkaiser merged 2 commits intoTheHPXProject:masterfrom May 4, 2026
Merged
Conversation
Up to standards ✅🟢 Issues
|
Collaborator
|
Can one of the admins verify this patch? |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes leftover stdexec-test guards and obsolete completion signature detection code, and updates async_mpi’s transform_mpi_* sender/receiver types to use the member-based P2300 receiver/sender shape instead of tag_invoke for set_*/connect.
Changes:
- Deleted dead stdexec-guarded tests/blocks in execution_base unit tests and removed the now-unused unit test target.
- Removed the obsolete
detail::has_completion_signaturestrait and its remaining test usage. - Migrated async_mpi
transform_mpi_receiver/transform_mpi_senderto memberset_value/set_error/set_stoppedand memberconnect(keepingtag_invoke(get_completion_signatures_t, ...)).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| libs/core/execution_base/tests/unit/test_tag_invoke_only_completion_signatures.cpp | Removed a unit test file that was effectively disabled by stdexec configuration. |
| libs/core/execution_base/tests/unit/coroutine_utils.cpp | Removed dead stdexec-guarded assertions for the removed awaitable-as-sender path; added explanatory note. |
| libs/core/execution_base/tests/unit/completion_signatures.cpp | Removed assertion that depended on the deleted has_completion_signatures trait. |
| libs/core/execution_base/tests/unit/CMakeLists.txt | Removed the deleted test target from the unit test list. |
| libs/core/execution_base/include/hpx/execution_base/completion_signatures.hpp | Deleted the obsolete detail::has_completion_signatures trait. |
| libs/core/async_mpi/include/hpx/async_mpi/transform_mpi.hpp | Updated transform_mpi sender/receiver to member-based P2300 forms for set_* and connect. |
hkaiser
added
type: enhancement
type: compatibility issue
type: cleanup
category: senders/receivers
guptapratykshh
force-pushed
the
cleanup/post-stdexec-followup
branch
from
95a3456 to
93f3ba2
Compare
… guards, and migrate async_mpi to native P2300 Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>
guptapratykshh
force-pushed
the
cleanup/post-stdexec-followup
branch
from
93f3ba2 to
477b25f
Compare
hkaiser
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Any background context you want to provide?
Checklist
Not all points below apply to all pull requests.